-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump k8s to 0.27.4 and golang to 1.20 #73
bump k8s to 0.27.4 and golang to 1.20 #73
Conversation
Signed-off-by: clyang82 <chuyang@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 80.52% 81.31% +0.78%
==========================================
Files 5 5
Lines 416 412 -4
==========================================
Hits 335 335
+ Misses 64 60 -4
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
e96e8fb
to
96b6f33
Compare
Signed-off-by: zhujian <jiazhu@redhat.com>
@@ -1,5 +1,8 @@ | |||
coverage: | |||
status: | |||
patch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open the informational mode for new code checking, so reviewers can know which new lines are not covered, and it also will not block the PR merge. https://docs.codecov.com/docs/commit-status#informational
/lgtm |
60c41e7
into
open-cluster-management-io:main
Co-authored-by: red-hat-konflux <123456+red-hat-konflux[bot]@users.noreply.github.com>
This PR resolved the conflicts of #66, and fixed the unit tests based on kubernetes-sigs/controller-runtime#2259
@clyang82, please help review